Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove unnecessary error enum and result type aliases #7875

Merged
merged 4 commits into from
Oct 17, 2023
Merged

refactor!: remove unnecessary error enum and result type aliases #7875

merged 4 commits into from
Oct 17, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 21, 2023 •
edited
Loading

ref: #7756

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 21, 2023 04:38
@amrbashir amrbashir mentioned this pull request Sep 21, 2023
Closed
14 tasks
@lucasfernog
Copy link
Member

We can't remove the plugin Result type because it needs to take a dyn std::error::Error to let plugin authors use their own error types.

@amrbashir
Copy link
Member Author

yeah it is fine to keep then.

@lucasfernog lucasfernog merged commit 12b8d18 into dev Oct 17, 2023
24 checks passed
@lucasfernog lucasfernog deleted the refactor/remove-unneeded-result-aliases branch October 17, 2023 16:10
@amrbashir
Copy link
Member Author

@lucasfernog would it make more sense to inline the type instead? just trying to avoid multiple result aliases when a user searches on docs.rs

@amrbashir amrbashir mentioned this pull request Oct 17, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog